jmuehlner commented on code in PR #966:
URL: https://github.com/apache/guacamole-client/pull/966#discussion_r1550659212
##########
extensions/guacamole-auth-duo/src/main/java/org/apache/guacamole/auth/duo/conf/ConfigurationService.java:
##########
@@ -69,26 +72,38 @@ public class ConfigurationService {
* received from Duo for verifying Guacamole users. This value MUST be
* exactly 40 characters.
*/
- private static final StringGuacamoleProperty DUO_SECRET_KEY =
+ private static final StringGuacamoleProperty DUO_CLIENT_SECRET =
new StringGuacamoleProperty() {
@Override
- public String getName() { return "duo-secret-key"; }
+ public String getName() { return "duo-client-secret"; }
};
-
+
Review Comment:
No bogus whitespace please.
##########
extensions/guacamole-auth-duo/src/main/java/org/apache/guacamole/auth/duo/conf/ConfigurationService.java:
##########
@@ -110,51 +125,65 @@ public String getAPIHostname() throws GuacamoleException {
}
/**
- * Returns the integration key received from Duo for verifying Guacamole
- * users, as defined in guacamole.properties by the "duo-integration-key"
+ * Returns the Duo client id received from Duo for verifying Guacamole
+ * users, as defined in guacamole.properties by the "duo-client-id"
* property. This value MUST be exactly 20 characters.
*
* @return
- * The integration key received from Duo for verifying Guacamole
- * users.
+ * The client id received from Duo for verifying Guacamole users.
*
* @throws GuacamoleException
* If the associated property within guacamole.properties is missing.
*/
- public String getIntegrationKey() throws GuacamoleException {
- return environment.getRequiredProperty(DUO_INTEGRATION_KEY);
+ public String getClientId() throws GuacamoleException {
+ return environment.getRequiredProperty(DUO_CLIENT_ID);
}
/**
- * Returns the secret key received from Duo for verifying Guacamole users,
- * as defined in guacamole.properties by the "duo-secret-key" property.
This
- * value MUST be exactly 20 characters.
+ * Returns the client secert received from Duo for verifying Guacamole
users,
+ * as defined in guacamole.properties by the "duo-client-secert" property.
Review Comment:
Typo: `secert`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
