corentin-soriano commented on code in PR #528: URL: https://github.com/apache/guacamole-server/pull/528#discussion_r1644685064
########## src/terminal/terminal-handlers.c: ########## @@ -835,6 +835,28 @@ int guac_terminal_csi(guac_terminal* term, unsigned char c) { break; + /* Scroll Up by amount */ + case 'S': + + /* Multiple linefeed */ + for (int i = 0; i < argv[0]; i++) + guac_terminal_linefeed(term, false); + + term->char_handler = guac_terminal_echo; Review Comment: Yes you are right, it is not useful since it is already assigned at line 1117 (in this branch). I removed them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@guacamole.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org