necouchman commented on code in PR #528:
URL: https://github.com/apache/guacamole-server/pull/528#discussion_r1644687721
##########
src/terminal/terminal-handlers.c:
##########
@@ -835,6 +835,24 @@ int guac_terminal_csi(guac_terminal* term, unsigned char
c) {
break;
+ /* Scroll Up by amount */
+ case 'S':
+
+ /* Multiple linefeed */
+ for (int i = 0; i < argv[0]; i++)
+ guac_terminal_linefeed(term, false);
Review Comment:
One other question - above, in the sections for inserting/deleting lines,
there are functions `guac_terminal_scroll_up` and `guac_terminal_scroll_down` -
is there a reason not to use these, versus using `for` loops you have here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
