corentin-soriano commented on code in PR #528: URL: https://github.com/apache/guacamole-server/pull/528#discussion_r1644737821
########## src/terminal/terminal-handlers.c: ########## @@ -835,6 +835,24 @@ int guac_terminal_csi(guac_terminal* term, unsigned char c) { break; + /* Scroll Up by amount */ + case 'S': + + /* Multiple linefeed */ + for (int i = 0; i < argv[0]; i++) + guac_terminal_linefeed(term, false); Review Comment: Yes, we can use these functions directly instead of doing a for loop. I changed and tested again: the result is the same. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@guacamole.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org