jmuehlner commented on code in PR #902:
URL: https://github.com/apache/guacamole-client/pull/902#discussion_r1759548069


##########
extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/usergroup/UserGroupMemberUserMapper.java:
##########
@@ -19,10 +19,65 @@
 
 package org.apache.guacamole.auth.jdbc.usergroup;
 
+import java.util.Collection;
 import org.apache.guacamole.auth.jdbc.base.ObjectRelationMapper;
+import org.apache.ibatis.annotations.Param;
 
 /**
  * Mapper for the one-to-many relationship between a user group and its user
  * members.
  */
-public interface UserGroupMemberUserMapper extends 
ObjectRelationMapper<UserGroupModel> {}
+public interface UserGroupMemberUserMapper extends 
ObjectRelationMapper<UserGroupModel> {
+
+    /**
+     * Inserts rows as necessary to establish the one-to-many relationship

Review Comment:
   This stuff about `RelatedObjectSet` is pretty abstract. It's not even clear 
just from reading this file what it's even about. Can you rephrase this (and 
any others) in terms of the specific relationships actually being modified?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@guacamole.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to