necouchman commented on PR #902: URL: https://github.com/apache/guacamole-client/pull/902#issuecomment-2355825514
Okay, I've gone through and tried to make sure comments are consistent. I think it's fixed up. I also believe I got the injection of the `SSOEnvironment` stuff correct in the SSO modules, but I still need to test, and it might be worth someone having a closer look at that. I also had another thought - I've done all of this work on a per-module basis, creating configuration options, etc. Does it make sense, instead, to do something like: * Global option for case-sensitivity across the entire Guacamole installation, instead of per-extension (`case-sensitive-usernames:`)? * Make the check for case sensitivity part of the `Environment` class, so that anything/everything that has access to that class can pull the status. * If username case-sensitivity is enabled, it is enabled across the board, for all the extensions; if it's disabled, it's disabled across the board for all extensions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@guacamole.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
