jmuehlner commented on code in PR #902:
URL: https://github.com/apache/guacamole-client/pull/902#discussion_r1762187095


##########
extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/user/UserMapper.java:
##########
@@ -33,10 +34,82 @@ public interface UserMapper extends 
ModeledDirectoryObjectMapper<UserModel> {
      *
      * @param username
      *     The username of the user to return.
+     * 
+     * @param caseSensitive
+     *     True if the search should evaluate usernames in a case-sensitive
+     *     manner, otherwise false.
      *
      * @return
      *     The user having the given username, or null if no such user exists.
      */
-    UserModel selectOne(@Param("username") String username);
+    UserModel selectOne(@Param("username") String username,
+                        @Param("caseSensitive") boolean caseSensitive);
+    
+    /**
+     * Selects all objects which have the given identifiers. If an identifier

Review Comment:
   Aren't these just users? Why be vague and call them objects? Unless I'm 
misunderstanding something here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@guacamole.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to