Github user mike-jumper commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-client/pull/161#discussion_r120279970
--- Diff:
extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/connection/ModeledConnection.java
---
@@ -117,12 +117,18 @@
public static final String MAX_CONNECTIONS_PER_USER_NAME =
"max-connections-per-user";
/**
+ * The connection weight for weighted algorithms.
+ */
+ public static final String CONNECTION_WEIGHT = "weight";
+
+ /**
* All attributes related to restricting user accounts, within a
logical
* form.
*/
public static final Form CONCURRENCY_LIMITS = new Form("concurrency",
Arrays.<Field>asList(
new NumericField(MAX_CONNECTIONS_NAME),
- new NumericField(MAX_CONNECTIONS_PER_USER_NAME)
+ new NumericField(MAX_CONNECTIONS_PER_USER_NAME),
+ new NumericField(CONNECTION_WEIGHT)
--- End diff --
Perhaps this should go in a different `Form`? As is, it will be rendered as
one of several fields in a group labeled "Concurrency Limits", which is not
what this relates to.
This would also help clean up the wording of the field itself, currently
"Connection Weight for Load Balancing", as locating the field within a section
titled "Load Balancing" (or similar) would remove the need to further qualify
"Connection Weight" with the phrase "for Load Balancing".
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
