Github user necouchman commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-client/pull/161#discussion_r120346221
--- Diff:
extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/tunnel/RestrictedGuacamoleTunnelService.java
---
@@ -180,8 +187,24 @@ protected ModeledConnection
acquire(RemoteAuthenticatedUser user,
@Override
public int compare(ModeledConnection a, ModeledConnection b) {
- return getActiveConnections(a).size()
- - getActiveConnections(b).size();
+ // Active connections
+ int Ca = getActiveConnections(a).size();
--- End diff --
Both the lack of camel case and the "Net Weight" came from referencing the
following pages:
http://kb.linuxvirtualserver.org/wiki/Weighted_Least-Connection_Scheduling
https://www.citrix.com/blogs/2010/10/01/load-balancing-weights/
https://www.citrix.com/blogs/2010/09/02/load-balancing-least-connections/
(as did the initial, and now-removed, concept of multiplying by the
arbitrary 10K number). Anyway, I don't know that "Net Weight" is actually
called out in those, but the Nw abbreviation is used in the Citrix page. I can
go with something else - computed weight or calculated weight - if that makes
more sense.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
