Github user mike-jumper commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-client/pull/161#discussion_r120277753
--- Diff:
extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/connection/ModeledConnection.java
---
@@ -393,6 +409,21 @@ public GuacamoleProxyConfiguration
getGuacamoleProxyConfiguration()
port != null ? port :
defaultConfig.getPort(),
encryptionMethod != null ? encryptionMethod :
defaultConfig.getEncryptionMethod()
);
+ }
+
+ /**
+ * Returns the weight of the connection, or a default
--- End diff --
Assuming the wording of the similar functions in `ConnectionModel` can be
clarified, I would suggest doing the same here, such that it's clear what the
"weight" of a connection means to someone looking at this function.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---