Github user necouchman commented on a diff in the pull request:

    
https://github.com/apache/incubator-guacamole-client/pull/180#discussion_r132605562
  
    --- Diff: 
extensions/guacamole-auth-cas/src/main/java/org/apache/guacamole/auth/cas/ticket/TicketValidationService.java
 ---
    @@ -75,6 +84,10 @@ public String processUsername(String ticket) throws 
GuacamoleException {
             catch (TicketValidationException e) {
                 throw new GuacamoleException("Ticket validation failed.", e);
             }
    +        catch (Throwable t) {
    +            logger.error("Error validating ticket with CAS server: {}", 
t.getMessage());
    +            throw new GuacamoleInsufficientCredentialsException("Error 
validating ticket with CAS server.", t, CredentialsInfo.USERNAME_PASSWORD);
    --- End diff --
    
    Still not sure this is the right exception to throw.  It's the one that 
works - that actually displays an error on the dialog box - but still seems a 
little weird to throw Insufficient instead of Invalid.  However, throwing 
Invalid and getting the error would require some additional reworking of the 
index controller.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to