Github user mike-jumper commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-client/pull/180#discussion_r134063008
--- Diff:
extensions/guacamole-auth-cas/src/main/java/org/apache/guacamole/auth/cas/ticket/TicketValidationService.java
---
@@ -75,6 +84,10 @@ public String processUsername(String ticket) throws
GuacamoleException {
catch (TicketValidationException e) {
throw new GuacamoleException("Ticket validation failed.", e);
}
+ catch (Throwable t) {
+ logger.error("Error validating ticket with CAS server: {}",
t.getMessage());
+ throw new GuacamoleInsufficientCredentialsException("Error
validating ticket with CAS server.", t, CredentialsInfo.USERNAME_PASSWORD);
--- End diff --
Internal errors really shouldn't be exposed to users of the system. If the
ticket can't be validated, then that should definitely be logged for the
administrator's sake, but such internals shouldn't make their way to the
interface.
Why not let the interface continue rendering all failures as "Invalid
login"?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
