Github user necouchman commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-client/pull/180#discussion_r134079492
--- Diff:
extensions/guacamole-auth-cas/src/main/java/org/apache/guacamole/auth/cas/ticket/TicketValidationService.java
---
@@ -75,6 +84,10 @@ public String processUsername(String ticket) throws
GuacamoleException {
catch (TicketValidationException e) {
throw new GuacamoleException("Ticket validation failed.", e);
}
+ catch (Throwable t) {
+ logger.error("Error validating ticket with CAS server: {}",
t.getMessage());
+ throw new GuacamoleInsufficientCredentialsException("Error
validating ticket with CAS server.", t, CredentialsInfo.USERNAME_PASSWORD);
--- End diff --
Okay, I can make the error more generic. However, throwing
GuacamoleInvalidCredentialsException does not display the red "Invalid Login"
error message when the username/password field is displayed - I think it has
something to do with the fact that the CAS authentication redirects away from
the Guacamole page and then back to it. So, unless there's some trick to
getting that to display, I have to stick with the InsufficientCredentials
exception.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
