Hi Jimmi, I will provide real performance numbers next week. Is it ok? I want to do some short article about this performance improvement with graphs and diagrams. But right now, I wish to fix all bugs before code freeze. I will reformat and remove printlns tomorrow. As for merging Java6's and Java5's TreeMaps I hope we can do it after M4.
On 12/4/07, Jimmy,Jing Lv <[EMAIL PROTECTED]> wrote: > > Hi, > > I have just read the patch for 5232 (sorry I did not notice this > last friday). It was really cool that TreeMap can got a improment in > performance (do you have some benchmark sorces on this, Sergey?) :) > > And as I read the source code, I find the main change was some > format problem, if I call an auto-format in eclipse and then compared > with previous version (Oct 27th's version), over 60% difference > disappeared! :) So format before commit is a good idea :) BTW, we may > remove all "System.out.println" in our source code(find in method > size()), do we? > > and for improment mentioned on JIRA: > 1. SubMap compared with upper bound key. > I do notice this and IIRC, there's a improvement in version 6. I'll > take a further study which is better :) > 2. SortedMap is downgraded to sorted array when in small size > A really great idea! Sergey you must be a cpu-guru, are you? :) It'll > be better If we can get some solid benchmark score. > > And for java6, TreeMap changes a lot in its lastest version, as a > result, we did a lot change in java6 TreeMap, including its structure > and inner classes. As I read the source code, I find it possible to > merge them together but will require effect on it as it was really > complex. Do we need to get it done before M4? If no, we can do the > refactor little by little till its complete. > > > 2007/12/4, Tim Ellison <[EMAIL PROTECTED]>: > > I just took a look at merging the latest changes into the Java 6 branch, > > and see that there is a collision in java.util.TreeMap and TreeSet. > > > > We had two contributions, > > > > HARMONY-4124 [classlib][luni][java6]TreeMap update to java 6 > > > > HARMONY-5232 [classlib][luni] TreeMap bug fixing and performance > > improvements > > > > which have introduced a discontinuity in the two implementations. > > > > I'd like to ask Sergey and Jimmy if these can be reconciled -- I don't > > think TreeMap changed so significantly between Java 5 and Java 6. It > > would be good to keep these in sync. > > > > Regards, > > Tim > > > > > -- > > Best Regards! > > Jimmy, Jing Lv > China Software Development Lab, IBM > -- Best regards, --- Sergey Kuksenko. Intel Enterprise Solutions Software Division.
