FYI: I will be holding a remote session with the HAWQ team based in Beijing to review the basic steps I used for the Apache HAWQ 2.0.0.0-incubator RC4 review. Needless to say I learned a significant amount over the past few weeks and will be sharing that experience.
-=e On Sat, Sep 24, 2016 at 11:15 AM, Ed Espino <[email protected]> wrote: > +1 > > Here are the review items I performed to support my vote: > > * Review LICENSE (including supporting files in licenses directory) > * Review NOTICE > * Review DISCLAIMER > * Review pom.xml (Apache RAT configuration) > * Checked the source package signature > * Successfully ran an Apache RAT check (maven verify) with results below > (full rat.txt attached for reference): > * Review JIRAS related to this release as identified by release manager. > All issues for the release have been resolved. > https://cwiki.apache.org/confluence/display/HAWQ/HAWQ+ > Release+2.0.0.0-incubating) > > NOTE(s): > * As this is an IP focused release, I did not perform a build. > > Regards, > -- > *Ed Espino* > *[email protected] <[email protected]>* > > > ##################################### > APACHE RAT EXECUTION > ##################################### > > ✔ ~/workspace/HAWQ-projects/apache-hawq-src-2.0.0.0-incubating > 10:58 $ mvn verify > [INFO] Scanning for projects... > [INFO] > > [INFO] ------------------------------------------------------------ > ------------ > [INFO] Building hawq 2.0 > [INFO] ------------------------------------------------------------ > ------------ > [INFO] > [INFO] --- apache-rat-plugin:0.11:check (default) @ hawq --- > [INFO] 51 implicit excludes (use -debug for more details). > [INFO] Exclude: tools/bin/src/stream/* > [INFO] Exclude: tools/bin/pythonSrc/PyGreSQL-4.0/** > [INFO] Exclude: tools/bin/pythonSrc/lockfile-0.9.1/** > [INFO] Exclude: tools/bin/pythonSrc/PSI-0.3b2_gp/** > [INFO] Exclude: tools/bin/ext/simplejson/** > [INFO] Exclude: tools/bin/ext/yaml/** > [INFO] Exclude: depends/libhdfs3/CMake/** > [INFO] Exclude: depends/libyarn/CMake/** > [INFO] Exclude: tools/bin/pythonSrc/pychecker-0.8.18/** > [INFO] Exclude: tools/bin/pythonSrc/unittest2-0.5.1/** > [INFO] Exclude: tools/bin/ext/figleaf/** > [INFO] Exclude: tools/bin/ext/pg8000/** > [INFO] Exclude: src/include/port/win32_msvc/bzlib.h > [INFO] Exclude: depends/thirdparty/googletest/** > [INFO] Exclude: contrib/orafce/* > [INFO] Exclude: tools/bin/lib/pexpect.py > [INFO] Exclude: src/bin/gpfdist/src/gpfdist/glob.c > [INFO] Exclude: src/bin/gpfdist/src/gpfdist/include/glob.h > [INFO] Exclude: src/include/port/win32_msvc/glob.h > [INFO] Exclude: aclocal.m4 > [INFO] Exclude: GNUmakefile.in > [INFO] Exclude: configure.in > [INFO] Exclude: configure > [INFO] Exclude: Makefile > [INFO] Exclude: config/* > [INFO] Exclude: src/makefiles/* > [INFO] Exclude: src/DEVELOPERS > [INFO] Exclude: src/backend/catalog/Makefile > [INFO] Exclude: src/backend/port/beos/*.c > [INFO] Exclude: src/backend/port/tas/*.s > [INFO] Exclude: src/backend/regex/re_syntax.n > [INFO] Exclude: src/backend/utils/mb/conversion_procs/regress_epilogue > [INFO] Exclude: src/backend/utils/mb/conversion_procs/regress_prolog > [INFO] Exclude: src/backend/utils/mb/Unicode/ISO10646-GB18030.TXT > [INFO] Exclude: src/backend/utils/misc/check_guc > [INFO] Exclude: src/backend/port/hpux/tas.c.template > [INFO] Exclude: src/backend/utils/mb/conversion_procs/proc.mk > [INFO] Exclude: src/include/pg_config.h.win32 > [INFO] Exclude: src/bin/scripts/common.h > [INFO] Exclude: src/include/pg_config.h.in > [INFO] Exclude: src/bin/initdb/* > [INFO] Exclude: src/bin/initlocation/* > [INFO] Exclude: src/bin/ipcclean/* > [INFO] Exclude: src/bin/pg_*/**/* > [INFO] Exclude: src/bin/psql/**/* > [INFO] Exclude: src/bin/scripts/*.c > [INFO] Exclude: src/interfaces/**/* > [INFO] Exclude: src/tools/**/* > [INFO] Exclude: src/tutorial/* > [INFO] Exclude: src/pl/**/* > [INFO] Exclude: src/port/* > [INFO] Exclude: src/template/* > [INFO] Exclude: src/test/**/* > [INFO] Exclude: src/timezone/**/* > [INFO] Exclude: doc/src/sgml/fixrtf > [INFO] Exclude: doc/**/*.sgml > [INFO] Exclude: depends/libhdfs3/test/data/* > [INFO] Exclude: depends/libhdfs3/debian/** > [INFO] Exclude: depends/libyarn/test/data/* > [INFO] Exclude: contrib/hawq-hadoop/hawq-mapreduce-common/src/test/ > resources/**/*.yaml > [INFO] Exclude: contrib/hawq-hadoop/hawq-mapreduce-tool/test-data/**/*. > yaml > [INFO] Exclude: contrib/hawq-hadoop/hawq-mapreduce-tool/src/test/ > resources/dataset > [INFO] Exclude: src/backend/access/index/caql.files > [INFO] Exclude: src/backend/gpopt/library.ver > [INFO] Exclude: src/backend/utils/misc/etc/slaves > [INFO] Exclude: tools/bin/.rcfile > [INFO] Exclude: tools/bin/postgresql_conf_gp_additions > [INFO] Exclude: tools/doc/**/* > [INFO] Exclude: tools/demo/gpfdist_transform/*.yaml > [INFO] Exclude: tools/bin/gppylib/operations/madlib_depcheck/changelist. > yaml > [INFO] Exclude: .git/** > [INFO] Exclude: **/*.md > [INFO] Exclude: **/*.md5 > [INFO] Exclude: **/*.json > [INFO] Exclude: **/*.ans > [INFO] Exclude: **/*.sql > [INFO] Exclude: **/*.out > [INFO] Exclude: **/*.po > [INFO] Exclude: **/*.map > [INFO] Exclude: **/*.stderr > [INFO] Exclude: **/*.stdout > [INFO] Exclude: **/*.source > [INFO] Exclude: **/*.txt > [INFO] Exclude: **/*.data > [INFO] Exclude: **/*.csv > [INFO] Exclude: **/*.pm > [INFO] Exclude: **/*.1 > [INFO] Exclude: **/*.sample > [INFO] Exclude: **/*.pgc > [INFO] Exclude: **/*.cnf > [INFO] Exclude: **/*.stx > [INFO] Exclude: **/*.gdb > [INFO] Exclude: **/*.patch > [INFO] Exclude: **/*.commit > [INFO] Exclude: **/__init__.py > [INFO] Exclude: **/*README* > [INFO] Exclude: **/.travis.yml > [INFO] Exclude: pxf/**/*.classpath > [INFO] 2898 resources included (use -debug for more details) > Warning: org.apache.xerces.jaxp.SAXParserImpl$JAXPSAXParser: Property ' > http://www.oracle.com/xml/jaxp/properties/entityExpansionLimit' is not > recognized. > Compiler warnings: > WARNING: 'org.apache.xerces.jaxp.SAXParserImpl: Property ' > http://javax.xml.XMLConstants/property/accessExternalDTD' is not > recognized.' > Warning: org.apache.xerces.parsers.SAXParser: Feature 'http://javax.xml. > XMLConstants/feature/secure-processing' is not recognized. > Warning: org.apache.xerces.parsers.SAXParser: Property 'http://javax.xml. > XMLConstants/property/accessExternalDTD' is not recognized. > Warning: org.apache.xerces.parsers.SAXParser: Property ' > http://www.oracle.com/xml/jaxp/properties/entityExpansionLimit' is not > recognized. > [INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 > approved: 2893 licence. > [INFO] ------------------------------------------------------------ > ------------ > [INFO] BUILD SUCCESS > [INFO] ------------------------------------------------------------ > ------------ > [INFO] Total time: 2.921 s > [INFO] Finished at: 2016-09-24T10:58:19-07:00 > [INFO] Final Memory: 12M/364M > [INFO] ------------------------------------------------------------ > ------------ > ✔ ~/workspace/HAWQ-projects/apache-hawq-src-2.0.0.0-incubating > 10:58 $ > > > > ##################################### > APACHE RAT OUTOUT > ##################################### > > ***************************************************** > Summary > ------- > Generated at: 2016-09-24T10:36:58-07:00 > Notes: 4 > Binaries: 0 > Archives: 1 > Standards: 2893 > > Apache Licensed: 2061 > Generated Documents: 0 > > JavaDocs are generated and so license header is optional > Generated files do not required license headers > > 0 Unknown Licenses > > ******************************* > > Unapproved licenses: > > > ******************************* > > Archives: > > + pxf/pxf-json/src/test/resources/tweets.tar.gz > > ***************************************************** > Files with Apache License headers will be marked AL > Binary files (which do not require AL headers) will be marked B > Compressed archives will be marked A > Notices, licenses etc will be marked N > PGSQL contrib/contrib-global.mk > AL contrib/extprotocol/gpextprotocol.c > AL contrib/extprotocol/Makefile > AL contrib/formatter_fixedwidth/fixedwidth.c > AL contrib/formatter_fixedwidth/Makefile > ... > <elided intentionally - Full report is attached> > ... > > AL tools/sbin/gpoperation.py > AL tools/sbin/hawqstandbywatch.py > AL tools/sbin/Makefile > > ***************************************************** > Printing headers for files without AL header... > > > > > On Sat, Sep 24, 2016 at 9:53 AM, Goden Yao <[email protected]> wrote: > >> This is the 1st release for Apache HAWQ (incubating), version: >> 2.0.0.0-incubating >> I want to take the opportunity to thank Ed, Roman and Justin for the final >> verification of all IP issues. >> >> *It fixes the following issues:* >> Clear all IP related issues for HAWQ and this is a source code tarball >> only >> release. >> Full list of JIRAs fixed/related to the release: link >> <https://cwiki.apache.org/confluence/display/HAWQ/HAWQ+Relea >> se+2.0.0.0-incubating> >> >> *** Please download, review and vote by *Friday 12pm Sep 30, 2016 PST* *** >> or When we have enough votes to bring this source tarball to IPMC >> >> *We're voting upon the release branch:* >> 2.0.0.0-incubating >> HEAD: commit >> <https://git-wip-us.apache.org/repos/asf?p=incubator-hawq. >> git;a=commit;h=6b2de9d09f86fa08cf4fef0dd4e3dbe3b1b3dfd5> >> >> To run check RAT, please do: >> >> $mvn verify >> >> first to get the correct RAT output. Look inside of pom.xml to see the >> classes of exceptions we're managing there for RAT. >> >> *Source Files:* >> https://dist.apache.org/repos/dist/dev/incubator/hawq/2.0.0. >> 0-incubating.RC4 >> >> *KEYS file containing PGP Keys we use to sign the release:* >> https://dist.apache.org/repos/dist/dev/incubator/hawq/KEYS >> (please note that I used new key to sign and my old key is going to be >> revoked) >> >> Thanks >> -Goden >> > > > > -- *Ed Espino* *[email protected] <[email protected]>*
