> On 2010-05-25 12:39:39, Todd Lipcon wrote: > > src/main/java/org/apache/hadoop/hbase/util/IncrementingEnvironmentEdge.java, > > line 17 > > <http://review.hbase.org/r/83/diff/1/?file=587#file587line17> > > > > may need to be synchronized, or use AtomicLong
Thanks Todd. - I'm modifying the HowToContribute page and didn't see a reference to the inclusion of the license header there or on the Code review page. I haven't committed my next change to the HowToContribute page yet, so I'm adding a reference there (plus modifying my files). - The singleton approach I think might be better. I thought that having the instance variable smelled a bit, that's why I asked about the fixed overhead. I'll make some changes. - IncrementingEE - I'll make some sync type changes here. I'll upload a new patch later today with these changes. - Daniel ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/83/#review56 ----------------------------------------------------------- On 2010-05-25 12:40:01, Daniel Ploeg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.hbase.org/r/83/ > ----------------------------------------------------------- > > (Updated 2010-05-25 12:40:01) > > > Review request for hbase. > > > Summary > ------- > > HBASE-2578 - Add ability for tests to override server-side timestamp setting > (currentTimeMillis). > The solution in this patch ensures that tests use a different timestamp with > a minimal change to the production code paths. > One question I would like to know is whether the change that was made to > HRegion.FIXED_OVERHEAD would cause any other side effects. > > > This addresses bug HBASE-2578. > http://issues.apache.org/jira/browse/HBASE-2578 > > > Diffs > ----- > > src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java 287cd48 > src/main/java/org/apache/hadoop/hbase/util/DefaultEnvironmentEdge.java > PRE-CREATION > src/main/java/org/apache/hadoop/hbase/util/EnvironmentEdge.java > PRE-CREATION > src/main/java/org/apache/hadoop/hbase/util/IncrementingEnvironmentEdge.java > PRE-CREATION > src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java d3716d6 > src/test/java/org/apache/hadoop/hbase/util/TestDefaultEnvironmentEdge.java > PRE-CREATION > > src/test/java/org/apache/hadoop/hbase/util/TestIncrementingEnvironmentEdge.java > PRE-CREATION > > Diff: http://review.hbase.org/r/83/diff > > > Testing > ------- > > > Thanks, > > Daniel > >
