> On 2010-05-25 18:15:35, Ryan Rawson wrote: > > src/main/java/org/apache/hadoop/hbase/util/EnvironmentEdgeManager.java, > > line 41 > > <http://review.hbase.org/r/83/diff/2/?file=643#file643line41> > > > > this is a lot of synchronization for what ends up being on the fast > > path of every query, perhaps there is a non synchronized manner in which we > > can accomplish this? the use of volatile might help here
thanks Ryan. I think I might use AtomicReference instead - can simplify even further this way. I'll upload another patch a bit later. - Daniel ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/83/#review72 ----------------------------------------------------------- On 2010-05-25 17:49:37, Daniel Ploeg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.hbase.org/r/83/ > ----------------------------------------------------------- > > (Updated 2010-05-25 17:49:37) > > > Review request for hbase. > > > Summary > ------- > > HBASE-2578 - Add ability for tests to override server-side timestamp setting > (currentTimeMillis). > The solution in this patch ensures that tests use a different timestamp with > a minimal change to the production code paths. > One question I would like to know is whether the change that was made to > HRegion.FIXED_OVERHEAD would cause any other side effects. > > > This addresses bug HBASE-2578. > http://issues.apache.org/jira/browse/HBASE-2578 > > > Diffs > ----- > > src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java 287cd48 > src/main/java/org/apache/hadoop/hbase/util/DefaultEnvironmentEdge.java > PRE-CREATION > src/main/java/org/apache/hadoop/hbase/util/EnvironmentEdge.java > PRE-CREATION > src/main/java/org/apache/hadoop/hbase/util/EnvironmentEdgeManager.java > PRE-CREATION > src/main/java/org/apache/hadoop/hbase/util/IncrementingEnvironmentEdge.java > PRE-CREATION > src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java d3716d6 > > src/test/java/org/apache/hadoop/hbase/util/EnvironmentEdgeManagerTestHelper.java > PRE-CREATION > src/test/java/org/apache/hadoop/hbase/util/TestDefaultEnvironmentEdge.java > PRE-CREATION > src/test/java/org/apache/hadoop/hbase/util/TestEnvironmentEdgeManager.java > PRE-CREATION > > src/test/java/org/apache/hadoop/hbase/util/TestIncrementingEnvironmentEdge.java > PRE-CREATION > > Diff: http://review.hbase.org/r/83/diff > > > Testing > ------- > > > Thanks, > > Daniel > >
