----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/83/#review62 -----------------------------------------------------------
What other possible approaches could we take to solving this issue? I seem to recalling a different strategy but I cannot recall it right now. We are really not set up for DI right now, and the ultimate direction of this patch is a fully dependency injected solution. src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java <http://review.hbase.org/r/83/#comment345> this seems overly HRegion specific - what is the "standard" mechanism for providing mocked out systems level time-based replacements? src/test/java/org/apache/hadoop/hbase/util/TestIncrementingEnvironmentEdge.java <http://review.hbase.org/r/83/#comment344> lets not use assertEquals(String,int,int) and just use assertEquals(int,int). - Ryan On 2010-05-25 12:40:01, Daniel Ploeg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.hbase.org/r/83/ > ----------------------------------------------------------- > > (Updated 2010-05-25 12:40:01) > > > Review request for hbase. > > > Summary > ------- > > HBASE-2578 - Add ability for tests to override server-side timestamp setting > (currentTimeMillis). > The solution in this patch ensures that tests use a different timestamp with > a minimal change to the production code paths. > One question I would like to know is whether the change that was made to > HRegion.FIXED_OVERHEAD would cause any other side effects. > > > This addresses bug HBASE-2578. > http://issues.apache.org/jira/browse/HBASE-2578 > > > Diffs > ----- > > src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java 287cd48 > src/main/java/org/apache/hadoop/hbase/util/DefaultEnvironmentEdge.java > PRE-CREATION > src/main/java/org/apache/hadoop/hbase/util/EnvironmentEdge.java > PRE-CREATION > src/main/java/org/apache/hadoop/hbase/util/IncrementingEnvironmentEdge.java > PRE-CREATION > src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java d3716d6 > src/test/java/org/apache/hadoop/hbase/util/TestDefaultEnvironmentEdge.java > PRE-CREATION > > src/test/java/org/apache/hadoop/hbase/util/TestIncrementingEnvironmentEdge.java > PRE-CREATION > > Diff: http://review.hbase.org/r/83/diff > > > Testing > ------- > > > Thanks, > > Daniel > >
