> On 2010-07-12 10:17:25, Nicolas wrote: > > /trunk/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java, > > line 860 > > <http://review.hbase.org/r/296/diff/1/?file=2378#file2378line860> > > > > probably should pre-allocate the ArrayList() size so we only deal with > > one heap element.
Good idea. > On 2010-07-12 10:17:25, Nicolas wrote: > > /trunk/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java, > > line 857 > > <http://review.hbase.org/r/296/diff/1/?file=2378#file2378line857> > > > > have you done any tests to see when the number of bloom checks takes > > significant time compared to just getting the block? For example, if you > > have 100 columns to lookup, do bloom filters really buy you anything, or > > shouldn't you just switch to a Row-level bloom anyways? Also, with a > > default 1% error rate, you're looking at ~100% false positive with 100 > > columns. Maybe max.columns = sqrt(1/error.rate) I have not, but would running on just the test data be sufficent to tell the true savings since the tests just run on mock data? I don't really have a dev cluster with real data that I can test this on, so perhaps you or someone could help out in that regard. - Kris ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/296/#review350 ----------------------------------------------------------- On 2010-07-11 22:54:42, Kris Jirapinyo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.hbase.org/r/296/ > ----------------------------------------------------------- > > (Updated 2010-07-11 22:54:42) > > > Review request for hbase. > > > Summary > ------- > > HBASE-2794 Enable bloom filter checks for multiple columns in same column > family > > > This addresses bug HBASE-2794. > http://issues.apache.org/jira/browse/HBASE-2794 > > > Diffs > ----- > > /trunk/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java > 962748 > > /trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreFile.java > 962748 > > Diff: http://review.hbase.org/r/296/diff > > > Testing > ------- > > Ran and passed org.apache.hadoop.hbase.regionserver.TestStoreFile multiple > times. Ran and passed all tests when building. > > > Thanks, > > Kris > >
