> On 2010-07-13 18:09:13, Nicolas wrote: > > /trunk/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java, > > line 958 > > <http://review.hbase.org/r/296/diff/3/?file=2723#file2723line958> > > > > red = using tabs instead of spaces or trailing spaces. quick fix might > > be nice (or is this auto-handled by svn, Stack?)
none of this is auto-handled by svn. need to setup eclipse or whatever you use to use 2 spaces instead of tabs. and in eclipse, i have my code cleanup set to remove whitespace and run that periodically. - Jonathan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/296/#review397 ----------------------------------------------------------- On 2010-07-13 16:32:18, Kris Jirapinyo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.hbase.org/r/296/ > ----------------------------------------------------------- > > (Updated 2010-07-13 16:32:18) > > > Review request for hbase. > > > Summary > ------- > > HBASE-2794 Enable bloom filter checks for multiple columns in same column > family > > > This addresses bug HBASE-2794. > http://issues.apache.org/jira/browse/HBASE-2794 > > > Diffs > ----- > > /trunk/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java > 963862 > /trunk/src/main/java/org/apache/hadoop/hbase/util/BloomFilter.java 963873 > /trunk/src/main/java/org/apache/hadoop/hbase/util/ByteBloomFilter.java > 963873 > > /trunk/src/main/java/org/apache/hadoop/hbase/util/DynamicByteBloomFilter.java > 963873 > > /trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreFile.java > 963873 > > Diff: http://review.hbase.org/r/296/diff > > > Testing > ------- > > Ran and passed org.apache.hadoop.hbase.regionserver.TestStoreFile multiple > times. Ran and passed all tests when building. > > > Thanks, > > Kris > >
