> On 2010-07-12 13:14:32, Kannan Muthukkaruppan wrote: > > /trunk/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java, > > line 880 > > <http://review.hbase.org/r/296/diff/1/?file=2378#file2378line880> > > > > can't this loop be over "columns" itself? And then inside the loop, you > > prepare one key at a time use Bytes.add(row, col). That way, you can avoid > > the keyList data structure completely.
Another good idea :) Will also get rid of the warning that keyList could possibly be null. - Kris ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/296/#review361 ----------------------------------------------------------- On 2010-07-11 22:54:42, Kris Jirapinyo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.hbase.org/r/296/ > ----------------------------------------------------------- > > (Updated 2010-07-11 22:54:42) > > > Review request for hbase. > > > Summary > ------- > > HBASE-2794 Enable bloom filter checks for multiple columns in same column > family > > > This addresses bug HBASE-2794. > http://issues.apache.org/jira/browse/HBASE-2794 > > > Diffs > ----- > > /trunk/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java > 962748 > > /trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreFile.java > 962748 > > Diff: http://review.hbase.org/r/296/diff > > > Testing > ------- > > Ran and passed org.apache.hadoop.hbase.regionserver.TestStoreFile multiple > times. Ran and passed all tests when building. > > > Thanks, > > Kris > >
