----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1271/#review2038 -----------------------------------------------------------
trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java <http://review.cloudera.org/r/1271/#comment6438> A new patch will be uploaded that reverts such changes. trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java <http://review.cloudera.org/r/1271/#comment6439> I think you're implying rewriting AssignmentManager.assignAllUserRegions(). How about creating this method: assignAllUserRegions(List<HRegionInfo> regions). finishInitialization() would pass null to the above method to indicate that all user regions should be assigned. createTable() would pass the list of regions for the new table. This way, BulkStartupAssigner doesn't appear in HMaster. trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java <http://review.cloudera.org/r/1271/#comment6440> Yes. I prefer space between if and left parenthesis. I will revert anyway. - Ted On 2010-12-06 10:42:26, Ted Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.cloudera.org/r/1271/ > ----------------------------------------------------------- > > (Updated 2010-12-06 10:42:26) > > > Review request for hbase, stack and Jonathan Gray. > > > Summary > ------- > > Adopted round-robin assignment as default for regions specified when table is > created. > > > This addresses bug HBASE-3305. > http://issues.apache.org/jira/browse/HBASE-3305 > > > Diffs > ----- > > trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java 1042725 > trunk/src/main/java/org/apache/hadoop/hbase/master/LoadBalancer.java > 1042725 > trunk/src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java 1042725 > > Diff: http://review.cloudera.org/r/1271/diff > > > Testing > ------- > > Put unit tests for this change inside TestAdmin.testCreateTableWithRegions() > They passed. > > > Thanks, > > Ted > >
