----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1271/#review2047 -----------------------------------------------------------
almost :) trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java <http://review.cloudera.org/r/1271/#comment6451> why is this and above import of EventType moved in your diff? trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java <http://review.cloudera.org/r/1271/#comment6452> white space here and two lines below trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java <http://review.cloudera.org/r/1271/#comment6453> put back the previous comment about round-robin, and whitespace (tabs?) trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java <http://review.cloudera.org/r/1271/#comment6454> Generally it's not good or "right" to catch, log, and ignore an IE. How is this handled elsewhere? - Jonathan On 2010-12-07 16:56:46, Ted Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.cloudera.org/r/1271/ > ----------------------------------------------------------- > > (Updated 2010-12-07 16:56:46) > > > Review request for hbase, stack and Jonathan Gray. > > > Summary > ------- > > Adopted round-robin assignment as default for regions specified when table is > created. > > > This addresses bug HBASE-3305. > http://issues.apache.org/jira/browse/HBASE-3305 > > > Diffs > ----- > > trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java > 1043216 > trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java 1043216 > trunk/src/main/java/org/apache/hadoop/hbase/master/LoadBalancer.java > 1043216 > trunk/src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java 1043216 > > Diff: http://review.cloudera.org/r/1271/diff > > > Testing > ------- > > Put unit tests for this change inside TestAdmin.testCreateTableWithRegions() > They passed. > > > Thanks, > > Ted > >
