----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1271/#review2042 -----------------------------------------------------------
Almost there. Some spacing only changes still in here and need to move out logic into AM method. trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java <http://review.cloudera.org/r/1271/#comment6445> still tabbing changes here and next method signature as well trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java <http://review.cloudera.org/r/1271/#comment6446> same as stack's original comment. this logic should be in AssignmentManager. I wouldn't reuse the method 'assignAllUserRegions' because it says "all" in it. A method 'assignUserRegions' which takes a list and does a bulk assign w/ round-robin would make sense . 'assignAllUserRegions' could then call it once it makes a list of regions. - Jonathan On 2010-12-06 23:22:29, Ted Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.cloudera.org/r/1271/ > ----------------------------------------------------------- > > (Updated 2010-12-06 23:22:29) > > > Review request for hbase, stack and Jonathan Gray. > > > Summary > ------- > > Adopted round-robin assignment as default for regions specified when table is > created. > > > This addresses bug HBASE-3305. > http://issues.apache.org/jira/browse/HBASE-3305 > > > Diffs > ----- > > trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java 1042922 > trunk/src/main/java/org/apache/hadoop/hbase/master/LoadBalancer.java > 1042922 > trunk/src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java 1042922 > > Diff: http://review.cloudera.org/r/1271/diff > > > Testing > ------- > > Put unit tests for this change inside TestAdmin.testCreateTableWithRegions() > They passed. > > > Thanks, > > Ted > >
