Thanks for the feedbacks. Let me sink this release. Balazs
On Wed, Apr 24, 2019 at 10:30 PM Sean Busbey <[email protected]> wrote: > -1 > > Bad: > * source artifact is missing NOTICE file > * binary artifacts is missing both LICENSE and NOTICE file > * maven repo artifact 'hbase-connectors-assembly' tgz is missing > LICENSE and NOTICE file > > Good: > * signatures good > * checksums good > * maven staged repo looks reasonable > > Nit: > * Why are we excluding README.md from rat instead of just giving them > headers? It should be the same as the headers we have in the generated > RELEASENOTES.md and CHANGELOG.md > * Worth a pass making sure relevant stuff has the correct fix version > and jira release notes so it ends up in RELEASENOTES and not just > CHANGELOG. In particular, this first release has two major things: the > kafka proxy (HBASE-15320) and the spark connector (HBASE-13992, > HBASE-14789). Neither of those are in RELEASENOTES, the spark ones > aren't included at all. > > > On Tue, Apr 23, 2019 at 7:27 AM Balazs Meszaros > <[email protected]> wrote: > > > > Please vote on this Apache HBase Connectors release candidate. > > > > The release files including signatures can be found at: > > http://home.apache.org/~meszibalu/hbase-connectors-1.0.0RC0/ > > and maven artifacts are available here: > > https://repository.apache.org/content/repositories/orgapachehbase-1305/ > > > > Artifacts were signed with [email protected] key which can be found > at: > > https://dist.apache.org/repos/dist/release/hbase/KEYS > > > > Compatibility information: > > - scala 2.11 > > - spark 2.4 > > - kafka 2.0 > > > > It's going to be the first release of hbase-connectors. I have updated > the > > documentation for kafka connector [1]. Please follow those steps when > > testing. Spark documentation is pretty good in the refguide [2]. > > > > Please note that HBASE-20884 [3] is required for spark, so HBase-2.0.4 or > > HBase-2.1.1 is required at least. > > > > Please try out the candidate and vote +1/0/-1. > > > > Let me be the first who votes. > > > > +1 (not surprisingly) > > > > - signatures, checksums: OK > > - apache rat check: OK > > - built from source (8u112): OK > > - unit tests: OK > > - kafka connector between hbase-2.1.4 and kafka-2.0.0 : OK > > - spark sql select / insert between hbase-2.1.4 and spark-2.4.0: OK > > > > Best regards, > > Balazs > > > > [1] https://github.com/apache/hbase-connectors/tree/master/kafka > > [2] http://hbase.apache.org/book.html#spark > > [3] https://issues.apache.org/jira/browse/HBASE-20884 >
