+1 (binding)
* xsums/sigs good
* KEYS up to date
* Can build/test from src
* L&N good for src
Nits:
* Binary release's LICENSE file is missing some stuff. e.g. we bundle
jcodings which is MIT licensed but that is not included in LICENSE. IMO,
we can come back and fix these for the next release.
* We get the ${project.basedir} in the local copy when building because
of the HBase dep of 2.1.0 doesn't have HBASE-21005. Do we want to choose
the latest 2.1.x?
* The rogue .flattened-pom.xml that shows up. Not sure who/what creates
that, but we should figure it out and squash it.
Thanks for putting this together Balazs!!
- Josh
On 4/26/19 9:02 AM, Balazs Meszaros wrote:
Please vote on this Apache HBase Connectors release candidate.
The release files including signatures can be found at:
http://home.apache.org/~meszibalu/hbase-connectors-1.0.0RC1/
and maven artifacts are available here:
https://repository.apache.org/content/repositories/orgapachehbase-1307/
Artifacts were signed with [email protected] key which can be found at:
https://dist.apache.org/repos/dist/release/hbase/KEYS
Compatibility information:
- scala 2.11
- spark 2.4
- kafka 2.0
It's going to be the first release of hbase-connectors. I have updated the
documentation for kafka connector [1]. Please follow those steps when
testing. Spark documentation is pretty good in the refguide [2].
Please note that HBASE-20884 [3] is required for spark, so HBase-2.0.4 or
HBase-2.1.1 is required at least.
Please try out the candidate and vote +1/0/-1.
Let me be the first who votes.
+1 (not surprisingly)
- signatures, checksums: OK
- apache rat check: OK
- built from source (8u112): OK
- unit tests: OK
- kafka connector between hbase-2.1.4 and kafka-2.0.0 : OK
- spark sql select / insert between hbase-2.1.4 and spark-2.4.0: OK
Best regards,
Balazs
[1] https://github.com/apache/hbase-connectors/tree/master/kafka
[2] http://hbase.apache.org/book.html#spark
[3] https://issues.apache.org/jira/browse/HBASE-20884
