+1 (non-binding)
signatures and sums for src: OK
signatures and sums for bin: OK
compile from src: OpenJDK 1.8.0_212-b04: OK
UTs: OK
ITs: OK
Ratcheck: OK
Additionally, the following nits found during review:
${project.basedir} is in the root of the project after compile
after build, RELEASENOTES.txt, README.txt, CHANGELOG.txt are not in the
built assembly
On Mon, Apr 29, 2019 at 6:53 AM Andor Molnar <[email protected]>
wrote:
> +1 (non-binding)
>
> - Checked signature, checksum
> - Built from source
> - Ran all unit / integration tests
>
> I did not run tests with Kafka / Spark.
>
> Regards,
> Andor
>
>
>
>
> On Sat, Apr 27, 2019 at 9:39 PM Stack <[email protected]> wrote:
>
> > +1
> >
> > Sig, hash, license, rat, and build from src all good (I see same detritus
> > as our Josh reports).
> >
> > Thanks Balazs,
> > S
> >
> > On Fri, Apr 26, 2019 at 6:02 AM Balazs Meszaros
> > <[email protected]> wrote:
> >
> > > Please vote on this Apache HBase Connectors release candidate.
> > >
> > > The release files including signatures can be found at:
> > > http://home.apache.org/~meszibalu/hbase-connectors-1.0.0RC1/
> > > and maven artifacts are available here:
> > >
> https://repository.apache.org/content/repositories/orgapachehbase-1307/
> > >
> > > Artifacts were signed with [email protected] key which can be found
> > at:
> > > https://dist.apache.org/repos/dist/release/hbase/KEYS
> > >
> > > Compatibility information:
> > > - scala 2.11
> > > - spark 2.4
> > > - kafka 2.0
> > >
> > > It's going to be the first release of hbase-connectors. I have updated
> > the
> > > documentation for kafka connector [1]. Please follow those steps when
> > > testing. Spark documentation is pretty good in the refguide [2].
> > >
> > > Please note that HBASE-20884 [3] is required for spark, so HBase-2.0.4
> or
> > > HBase-2.1.1 is required at least.
> > >
> > > Please try out the candidate and vote +1/0/-1.
> > >
> > > Let me be the first who votes.
> > >
> > > +1 (not surprisingly)
> > >
> > > - signatures, checksums: OK
> > > - apache rat check: OK
> > > - built from source (8u112): OK
> > > - unit tests: OK
> > > - kafka connector between hbase-2.1.4 and kafka-2.0.0 : OK
> > > - spark sql select / insert between hbase-2.1.4 and spark-2.4.0: OK
> > >
> > > Best regards,
> > > Balazs
> > >
> > > [1] https://github.com/apache/hbase-connectors/tree/master/kafka
> > > [2] http://hbase.apache.org/book.html#spark
> > > [3] https://issues.apache.org/jira/browse/HBASE-20884
> > >
> >
>
