Sorry I didn't mention it here, but when voting I reopened HBASE-21800 and HBASE-21991. These introduced changes to LossyCounting, which is currently IA.Public. I asked the contributor on JIRA to provide a patch for the incompatibility. Maybe this class shouldn't be IA.Public; I'd be fine with that here. But we should make sure we either make it not public with a proper release note or fix it.
On Thu, May 9, 2019 at 8:41 PM Andrew Purtell <andrew.purt...@gmail.com> wrote: > As was pointed out on another thread it's my personal take to be treating > -1 votes as vetos, so as point of order this is not a veto. Apologies for > causing any confusion there. As the remainder of my response, I think the > call to courtesy in those words should stand and are submitted for your > consideration. > > On Thu, May 9, 2019 at 9:29 AM Andrew Purtell <andrew.purt...@gmail.com> > wrote: > > > Are you referring to the changes I called out in HBASE-22215 or something > > else? If HBASE-22215 please do us the courtesy of reopening it with your > > objection, because the change was given due consideration there already. > > > > Additive changes to LP classes are allowed, I believe, but you will need > > to be more specific. I can only guess what you are looking at. > > > > Currently this veto is not valid because it does not indicate what the > > actual problem is. Please file a JIRA with your instructions to remedy > the > > problem. At the very least list the items you feel are at issue. > > > > > On May 9, 2019, at 2:53 AM, Peter Somogyi <psomo...@apache.org> wrote: > > > > > > -1 > > > > > > Compatibility report shows removed methods and changed constructor > > > signature for a IA.Public interface. There are also a couple of changes > > for > > > IA.LP classes. > > > > > > Also checked: > > > Checksum, signature OK > > > Rat check OK > > > Unit tests OK > > > Simple shell commands OK > > > LTT 1M rows OK > > > Master, RS UI OK > > > > > >> On Sat, May 4, 2019 at 3:07 AM Andrew Purtell <apurt...@apache.org> > > wrote: > > >> > > >> Pardon me, there is a typo on the close date for the vote. I would > like > > to > > >> close the vote by or on May 10, 2019. The tenth, not the nineteenth, > > thank > > >> you. > > >> > > >> > > >>> On Fri, May 3, 2019 at 6:04 PM Andrew Purtell <apurt...@apache.org> > > wrote: > > >>> > > >>> The first HBase 1.4.10 release candidate (RC0) is available for > > download > > >>> at https://dist.apache.org/repos/dist/dev/hbase/hbase-1.4.10RC0/ and > > >>> Maven artifacts are available in the temporary repository > > >>> > https://repository.apache.org/content/repositories/orgapachehbase-1310 > > . > > >>> > > >>> The git tag corresponding to the candidate is '1.4.10RC0' > (8a597e477e). > > >>> > > >>> A detailed source and binary compatibility report for this release is > > >>> available for your review at > > >>> > > >> > > > https://dist.apache.org/repos/dist/dev/hbase/hbase-1.4.10RC0/compat-check-report.html > > >>> . There are no reported compatibility issues of concern. The changes > to > > >>> Public annotated class MultiRowRangeFilter are reported as low impact > > by > > >>> the compatibility checker tool and were discussed and allowed on > > >>> . > > >>> > > >>> A list of the 57 issues resolved in this release can be found at > > >>> https://s.apache.org/7gSD . > > >>> > > >>> Please try out the candidate and vote +1/0/-1. > > >>> > > >>> The vote will be open for at least 72 hours. Unless objection I will > > try > > >>> to close it Friday May 19, 2019 if we have sufficient votes. > > >>> > > >>> Prior to making this announcement I made the following preflight > > checks: > > >>> > > >>> RAT check passes (7u80) > > >>> Unit test suite passes 5/5 (7u80, 8u172) > > >>> LTT load 100M rows with 100% verification and 20% updates (8u181) > > >>> > > >>> > > >>> -- > > >>> Best regards, > > >>> Andrew > > >>> > > >>> > > >> > > >> -- > > >> Best regards, > > >> Andrew > > >> > > >> Words like orphans lost among the crosstalk, meaning torn from truth's > > >> decrepit hands > > >> - A23, Crosstalk > > >> > > > > > -- > Best regards, > Andrew > > Words like orphans lost among the crosstalk, meaning torn from truth's > decrepit hands > - A23, Crosstalk >
