If we run a single combination, I'd prefer JDK8+Hadoop3. That would at least quickly catch any newer features used in the code. Running tests with JDK11 only is the least useful combination, as it will detect neither JDK8 nor JDK11+ incompatibilities.
Also, if the staggered nightlies fix the queue issues, we don't necessatily have to change the PR jobs. Istvan On Sun, Jan 12, 2025 at 3:51 PM 张铎(Duo Zhang) <palomino...@gmail.com> wrote: > Filed HBASE-29069. > > 张铎(Duo Zhang) <palomino...@gmail.com> 于2025年1月12日周日 22:43写道: > > > > So the decision is to only keep jdk11 + hadoop3 test for branch-2.x > > pre commit build? > > > > For me I think it is OK. > > > > Istvan Toth <st...@cloudera.com.invalid> 于2025年1月11日周六 20:51写道: > > > > > > Fine by me. > > > > > > > > > On Fri, Jan 10, 2025 at 9:41 PM Andrew Purtell <apurt...@apache.org> > wrote: > > > > > > > > jdk8+hadoop2 precommit tests on branch-2.x, > > > > > > > > We could, although is anyone still using Hadoop 2? I think we should > test > > > > JDK8 + Hadoop 3 if we have to pick one combination. > > > > > > > > 2.x is effectively EOM, no release since 2.10.2 on May 31 2022, > according > > > > to the Hadoop release download page. It's now going on three years > later, > > > > to state the obvious. Honestly, no HBase user should be using it -- > it's > > > > full of CVE documented security issues, either directly or by way of > first > > > > order dependencies -- unless the HBase+Hadoop service is itself in a > legacy > > > > or maintenance mode and no further changes are necessary, not even > security > > > > updates. > > > > > > > > > > > > On Fri, Jan 10, 2025 at 11:07 AM Istvan Toth > <st...@cloudera.com.invalid> > > > > wrote: > > > > > > > > > Trying to consolidate the topic on this thread: > > > > > > > > > > I'd probably keep the jdk8+hadoop2 precommit tests on branch-2.x, > the > > > > other > > > > > combinations have hopefully been tested on master/branch-3 before > > > > > backporting. > > > > > > > > > > Yes, branch-3 and master only run one full test suite as opposed to > > > > three. > > > > > > > > > > We could also disable the new Hadoop version specific tests if we > must, > > > > or > > > > > at least only run them on the oldest supported Hadoop version, and > not on > > > > > the intermediate ones. > > > > > > > > > > Istvan > > > > > > > > > > > > > > > On Fri, Jan 10, 2025 at 7:16 PM Andrew Purtell < > andrew.purt...@gmail.com > > > > > > > > > > wrote: > > > > > > > > > > > +1 to skipping alternative JDK and Hadoop tests on all branches. > > > > > > > > > > > > > On Jan 9, 2025, at 9:46 AM, Istvan Toth <st...@apache.org> > wrote: > > > > > > > > > > > > > > Hi! > > > > > > > > > > > > > > Some ideas to mitigate the queue issues: > > > > > > > > > > > > > > 1. Disable the alternate JDK/Hadoop tests for the precommit PR > (any > > > > > > > problems would still be discovered later in the nightlies) > > > > > > > 2. Stagger the nightly tests: Run 2.5 and 2.6 on odd days, and > > > > > branch-2 > > > > > > , > > > > > > > branch-3 and master on even days > > > > > > > > > > > > > > The first one is quite simple to do, the second one would be a > little > > > > > > more > > > > > > > involved. > > > > > > > > > > > > > > WDYT ? > > > > > > > > > > > > > > > > > > > > > -- > > > > > *István Tóth* | Sr. Staff Software Engineer > > > > > *Email*: st...@cloudera.com > > > > > cloudera.com <https://www.cloudera.com> > > > > > [image: Cloudera] <https://www.cloudera.com/> > > > > > [image: Cloudera on Twitter] <https://twitter.com/cloudera> > [image: > > > > > Cloudera on Facebook] <https://www.facebook.com/cloudera> [image: > > > > Cloudera > > > > > on LinkedIn] <https://www.linkedin.com/company/cloudera> > > > > > ------------------------------ > > > > > ------------------------------ > > > > > > > > > > > > > > > > > -- > > > > Best regards, > > > > Andrew > > > > > > > > Unrest, ignorance distilled, nihilistic imbeciles - > > > > It's what we’ve earned > > > > Welcome, apocalypse, what’s taken you so long? > > > > Bring us the fitting end that we’ve been counting on > > > > - A23, Welcome, Apocalypse > > > > > > > > > > > > > -- > > > *István Tóth* | Sr. Staff Software Engineer > > > *Email*: st...@cloudera.com > > > cloudera.com <https://www.cloudera.com> > > > [image: Cloudera] <https://www.cloudera.com/> > > > [image: Cloudera on Twitter] <https://twitter.com/cloudera> [image: > > > Cloudera on Facebook] <https://www.facebook.com/cloudera> [image: > Cloudera > > > on LinkedIn] <https://www.linkedin.com/company/cloudera> > > > ------------------------------ > > > ------------------------------ > -- *István Tóth* | Sr. Staff Software Engineer *Email*: st...@cloudera.com cloudera.com <https://www.cloudera.com> [image: Cloudera] <https://www.cloudera.com/> [image: Cloudera on Twitter] <https://twitter.com/cloudera> [image: Cloudera on Facebook] <https://www.facebook.com/cloudera> [image: Cloudera on LinkedIn] <https://www.linkedin.com/company/cloudera> ------------------------------ ------------------------------