Github user dmap commented on the issue:

    https://github.com/apache/httpcomponents-core/pull/94
  
    > I will not insist but it would be nice to factor the SOCKS protocol logic 
out into a `IOEventHandler` The basic idea is to have individual 
`IOEventHandler` do their job, like HTTP protocol negotiation or SOCKS 
handshake, and then pass control to another `IOEventHandler`.
    
    I attempted this approach.  It worked fine for plain connections but for 
SSL connections the SSL handling triggered in the `InternalDataChannel` got in 
the way before the `IOEventHandler` implementation got a chance to do its job.  
As I mentioned previously the SOCKS negotiation needs to happen before the 
TLS/SSL handshaking, not after.  Without refactoring of `InternalDataChannel` 
it isn't possible to use an `IOEventHandler` to do the SOCKS negotiation.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to