Github user dmap commented on the issue:
https://github.com/apache/httpcomponents-core/pull/94
@ok2c @garydgregory So I have just pushed a set of tests for the new code.
These are reasonably extensive in that they simply inherit from the existing
integration tests but using a SOCKS proxy... and yes that means I wrote a
simple SOCKS proxy server for the test framework. It means we get all the
current integration tests for Http1 and Http2 run again, but through a SOCKS
proxy.
These tests all pass perfectly using the `InternalConnectSocksChannel`
implementation. If you switch to the `SocksProxyProtocolHandler`
implementation instead a large number of them fail with all sorts of strange
behaviour. I expected the SSL ones to fail, but many of the plain HTTP tests
also fail with various things hanging and timing out. That means there is
probably a race condition in there somewhere, but I can't see where. It might
not be in my code, like I said the `InternalConnectSocksChannel` works fine.
I feel my work here is essentially done. I would love to see this merged
into the codebase, but that ball is in your court now. I can quite happily
drive my own testing from my own fork.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
