On Wed, Feb 6, 2019 at 7:49 PM Gary Gregory <[email protected]> wrote:

> Oleg and all:
>
> Would you please take a look
> at 
> org.apache.hc.core5.http.impl.bootstrap.CustomAsyncServerBootstrap.createRequestHandlerRegistry()
> in the branch HTTPCORE-570.
>
> The TODO comment, I believe surfaces a mistake in our generic typing
> of RequestHandlerRegistry or at least that one ctor.
>
> IOW, why doesn't this compile in CustomAsyncServerBootstrap:
>
>         Supplier<LookupRegistry<AsyncServerExchangeHandler>> supplier =
> new Supplier<LookupRegistry<AsyncServerExchangeHandler>>() {...};
>         RequestHandlerRegistry<Supplier<AsyncServerExchangeHandler>>
> registry = new RequestHandlerRegistry<>(
>                 actualCanonicalHostName, supplier);
>
>
Note the compiler warnings for callers
of 
org.apache.hc.core5.http.protocol.RequestHandlerRegistry.RequestHandlerRegistry(String,
Supplier<LookupRegistry<T>>)

Gary


> Thank you,
> Gary
>
>
> On Wed, Feb 6, 2019 at 4:14 PM Gary Gregory <[email protected]>
> wrote:
>
>> Please see:
>> - https://issues.apache.org/jira/browse/HTTPCORE-569 and branch
>> HTTPCORE-569
>> - https://issues.apache.org/jira/browse/HTTPCORE-570 and branch
>> HTTPCORE-570
>> Gary
>>
>> On Wed, Feb 6, 2019 at 2:39 PM Gary Gregory <[email protected]>
>> wrote:
>>
>>> I have a new feature I'd like to discuss which I'd love to see in Beta
>>> 7, I am writing the Jira now which we can discuss in a sec...
>>>
>>> Gary
>>>
>>> On Tue, Feb 5, 2019 at 4:29 PM Ryan Schmitt <[email protected]> wrote:
>>>
>>>> https://issues.apache.org/jira/browse/HTTPCORE-568
>>>>
>>>> On Tue, Feb 5, 2019 at 6:39 AM Oleg Kalnichevski <[email protected]>
>>>> wrote:
>>>>
>>>> > Ryan et al
>>>> >
>>>> > Would you like me to cut 5.0-beta7 this weekend or should you like to
>>>> > be a release manager for this release?
>>>> >
>>>> > Oleg
>>>> >
>>>> >
>>>> >
>>>> > ---------------------------------------------------------------------
>>>> > To unsubscribe, e-mail: [email protected]
>>>> > For additional commands, e-mail: [email protected]
>>>> >
>>>> >
>>>>
>>>

Reply via email to