On Fri, 2019-02-15 at 16:06 -0500, Gary Gregory wrote: > On Wed, Feb 6, 2019 at 7:49 PM Gary Gregory <[email protected]> > wrote: > > > Oleg and all: > > > > Would you please take a look > > at > > org.apache.hc.core5.http.impl.bootstrap.CustomAsyncServerBootstrap. > > createRequestHandlerRegistry() > > in the branch HTTPCORE-570. > > > > The TODO comment, I believe surfaces a mistake in our generic > > typing > > of RequestHandlerRegistry or at least that one ctor. > > > > IOW, why doesn't this compile in CustomAsyncServerBootstrap: > > > > Supplier<LookupRegistry<AsyncServerExchangeHandler>> > > supplier = > > new Supplier<LookupRegistry<AsyncServerExchangeHandler>>() {...}; > > RequestHandlerRegistry<Supplier<AsyncServerExchangeHandler> > > > > > registry = new RequestHandlerRegistry<>( > > actualCanonicalHostName, supplier); > > > > > > Note the compiler warnings for callers > of > org.apache.hc.core5.http.protocol.RequestHandlerRegistry.RequestHandl > erRegistry(String, > Supplier<LookupRegistry<T>>) > > Gary >
Hi Gary I see no warning neither in the IDE nor compiling with Maven [INFO] --- maven-compiler-plugin:3.8.0:compile (default-compile) @ httpcore5 --- [INFO] Toolchain in maven-compiler-plugin: JDK[/opt/oracle-jdk-1.7.0] [INFO] Changes detected - recompiling the module! [INFO] Compiling 472 source files to /home/oleg/src/apache.org/httpcomponents/httpcore-5.x/httpcore5/target/classes [WARNING] /home/oleg/src/apache.org/httpcomponents/httpcore-5.x/httpcore5/src/main/java/org/apache/hc/core5/reactor/ssl/SSLIOSession.java:[212,16] [deprecation] lock() in IOSession has been deprecated [WARNING] /home/oleg/src/apache.org/httpcomponents/httpcore-5.x/httpcore5/src/main/java/org/apache/hc/core5/reactor/InternalDataChannel.java:[270,16] [deprecation] lock() in IOSession has been deprecated [WARNING] /home/oleg/src/apache.org/httpcomponents/httpcore-5.x/httpcore5/src/main/java/org/apache/hc/core5/reactor/IOSessionImpl.java:[93,16] [deprecation] lock() in IOSession has been deprecated [INFO] Oleg --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
