On Mon, 2021-03-15 at 10:40 +0100, Julian Reschke wrote: > Am 09.02.2021 um 19:28 schrieb Oleg Kalnichevski: > > ... > > Hi Julian > > > > I will try to get around to taking a look. Anyway whenever you are > > ready just raise a PR. > > > > Cheers > > > > Oleg > > ... > > I'd prefer to get it first into the right shape in-place - before > attempting a PR. > > You said earlier: > > > ... I would also ask you to make your code a bit more > > consistent with the rest of the code base once you have a PR ready. > > Could you be a bit more specific what you're looking for? >
Hi Julian Pretty much all message parsing routines in core [1] and client are based on Tokenizer [2]. Those parsers are forward-only and produce near zero (or fairly little) intermediate garbage. Id would be nice if parsing code in Structured Field Values re-used some of the message element parsers or were based on the Tokenizer if possible. Oleg [1] https://github.com/apache/httpcomponents-core/tree/master/httpcore5/src/main/java/org/apache/hc/core5/http/message [2] https://github.com/apache/httpcomponents-core/blob/master/httpcore5/src/main/java/org/apache/hc/core5/util/Tokenizer.java > Best regards, Julian > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
