On Tue, 2021-03-16 at 15:11 +0100, Julian Reschke wrote: > Am 16.03.2021 um 14:40 schrieb Gary Gregory: > > I agree with Oleg, please consider contributing as joining a > > community, not > > just providing source code. > > > > Otherwise, a code dump can just happen anywhere. > > > > Gary > > I understand that sentiment (I wouldn't want a big, unmaintained code > drop in Apache Jackrabbit either :-). > > Looking at the code shows that it's currently ~2K of lines, of which > 900 > are in the actual Parser. The remainder implements the "object model" > for structured fields plus serialization. > > So the question is how much of the actual parser (please have a look > at > < > https://github.com/reschke/structured-fields/blob/master/src/main/java/org/greenbytes/http/sfv/Parser.java> > ;) > can benefit of re-using Tokenizer. >
All of it. The code in Tokenizer has been around for over a decade and is also being used by Apache Mime4j. It is reasonably simple and flexible with reasonable performance characteristics. I understand you are reluctant to rewrite your code but I would prefer bits of your parser getting folded into the existing message parsers and formatters instead of being completely detached from the rest of the code base. That would not only help your code find a home but would also benefit the project itself. Otherwise you might really be better off hosting it on GitHub and referencing it as a companion project on HC web site http://hc.apache.org/httpcomponents-client-5.0.x/related-projects.html Oleg --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
