On Tue, 2021-03-16 at 17:19 +0100, Julian Reschke wrote: > Am 16.03.2021 um 16:53 schrieb Oleg Kalnichevski: > > ... > > > So the question is how much of the actual parser (please have a > > > look > > > at > > > < > > > https://github.com/reschke/structured-fields/blob/master/src/main/java/org/greenbytes/http/sfv/Parser.java> > > > ;) > > > can benefit of re-using Tokenizer. > > > > > > > All of it. The code in Tokenizer has been around for over a decade > > and > > is also being used by Apache Mime4j. It is reasonably simple and > > flexible with reasonable performance characteristics. > > "All of it" seems... far fetched. Please have a lopk at the code; > large > parts are concerned with things that have nothing to do whatsoever > with > what Tokenizer does (such as parsing numbers, building lists etc). >
Oh, well. We can agree to disagree like so many times before. I do think all of your code would benefit from re-using existing parsing and formatting primitives used by the rest of the library. Oleg --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
