ok2c commented on a change in pull request #296:
URL:
https://github.com/apache/httpcomponents-client/pull/296#discussion_r601693927
##########
File path:
httpclient5/src/main/java/org/apache/hc/client5/http/config/RequestConfig.java
##########
@@ -43,7 +43,6 @@
public class RequestConfig implements Cloneable {
private static final Timeout DEFAULT_CONNECTION_REQUEST_TIMEOUT =
Timeout.ofMinutes(3);
- private static final Timeout DEFAULT_CONNECT_TIMEOUT =
Timeout.ofMinutes(3);
private static final TimeValue DEFAULT_CONN_KEEP_ALIVE =
TimeValue.ofMinutes(3);
Review comment:
@carterkozak To me, this is clearly an HTTP protocol layer
responsibility, but if you, guys, are absolutely convinced I can move this
setting to `ConnectionConfig`. The connection management layer is in control of
TTL (total time to live), which is a slightly different thing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
