rschmitt commented on PR #773:
URL:
https://github.com/apache/httpcomponents-client/pull/773#issuecomment-3792983170
> @rschmitt As far as this specific change-set is concerned, what are your
specific objections? You would want me to remove the option of disabling system
properties? That is fine by me. What else? You want no API changes at all? What
are we supposed to do with `#createDefault` and `#createSystem` factory
methods? We cannot just leave them be, can we?
I would mark the `#createSystem` methods `@Deprecated` and change them to
delegate to `#createDefault`. Similarly, we would deprecate
`#useSystemProperties` and document it as a no-op. This is much less disruptive
than deprecating the methods that most people are currently using, and it
doesn't introduce any new methods.
Just to see what would happen, I made this change locally and it's
significantly smaller:
```
================== core ==================
.../main/java/org/apache/hc/core5/ssl/SSLContexts.java | 15
+++++----------
.../java/org/apache/hc/core5/ssl/SSLContextsTest.java | 4 ++--
2 files changed, 7 insertions(+), 12 deletions(-)
================== client ==================
.../http/impl/async/H2AsyncClientBuilder.java | 24 ++++++------------
.../http/impl/async/HttpAsyncClientBuilder.java | 24 ++++--------------
.../client5/http/impl/async/HttpAsyncClients.java | 9 ++++---
.../http/impl/classic/HttpClientBuilder.java | 24 ++++--------------
.../hc/client5/http/impl/classic/HttpClients.java | 7 ++----
.../PoolingHttpClientConnectionManagerBuilder.java | 15 +++--------
...PoolingAsyncClientConnectionManagerBuilder.java | 19 +++-----------
.../client5/http/ssl/ClientTlsStrategyBuilder.java | 15 +++--------
.../http/ssl/ConscryptClientTlsStrategy.java | 9 ++-----
.../client5/http/ssl/DefaultClientTlsStrategy.java | 11 +++-----
.../ssl/SSLConnectionSocketFactoryBuilder.java | 29
+++-------------------
.../hc/client5/http/examples/AsyncClientSNI.java | 2 +-
.../apache/hc/client5/http/examples/ClientSNI.java | 2 +-
.../http/examples/ClientSpkiPinningExample.java | 2 +-
14 files changed, 46 insertions(+), 146 deletions(-)
```
All the tests pass, with only `SSLContextsTest` needing to be changed. If
you want, I could refine these changes and submit them as PRs.
https://github.com/rschmitt/httpcomponents-core/commit/system
https://github.com/rschmitt/httpcomponents-client/commit/system
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
