rschmitt commented on PR #773:
URL:
https://github.com/apache/httpcomponents-client/pull/773#issuecomment-3751118437
I think we can keep support for `proxyUser`/`proxyPassword` as long as we
delegate to `java.net.Authenticator` first. I'll also note that this code looks
wrong, since there are other ways to enable a proxy:
```java
private static PasswordAuthentication getProxyCredentials(final String
protocol, final AuthScope authScope) {
final String proxyHost = System.getProperty(protocol + ".proxyHost");
if (proxyHost == null) {
return null;
}
final String proxyPort = System.getProperty(protocol + ".proxyPort");
if (proxyPort == null) {
return null;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
