jonenst commented on PR #773: URL: https://github.com/apache/httpcomponents-client/pull/773#issuecomment-3795523354
Hi, thinking a bit more about your proposal, a nice thing is that users will also be able to fix broken/lacking tools without waiting for their new releases with new code (just drop the new httpcomponents jar) (barring other incompatibilities) Also, another thought. If a developper writes a new tool/lib (without thinking about and writing the code for proxy auth) and uses the jdk clients (URLConnection or HttpClient), it will do the same as your proposal : only give locus of control to the user for proxyHost (as an aside here, note that your proposal viewed from this angle almost feels like fixing a bug and catching up with the jdk features...). So to me it really comes down to whether you want to challenge the jdk and java status quo on proxy basic auth. For what it's worth, a notable example that brings a lot of light to httpcomponents of challenging the status quo is allowing the PATCH http method (disallowed in the jdk clients). Maybe the same reasoning can be applied to proxy auth ? (Real question, I don't know for sure)) Cheers, Jon -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
