ok2c commented on code in PR #686:
URL:
https://github.com/apache/httpcomponents-core/pull/686#discussion_r3702527230
##########
httpcore5/src/test/java/org/apache/hc/core5/http/ssl/TestTlsCiphers.java:
##########
@@ -94,14 +95,306 @@ void testExcludeWeakNull() {
Assertions.assertNull(TlsCiphers.excludeWeak((String[]) null));
}
+
@Disabled("https://lists.apache.org/thread/2z09rjxv0wpss2gvv9jl8yq9wlst8qmh";)
+ @ParameterizedTest
+ @MethodSource("org.apache.hc.core5.http.ssl.TlsCiphers#getH2Blacklisted()")
+ void testH2BlacklistedIsWeak(final String h2BlacklistedCipherSuite) {
Review Comment:
@garydgregory I do not feel very strongly about it. I presume HTTP/2 can be
blacklisting ciphers for various reasons, being weak just one. Anyway, feel
free to find out what HTTP/2 ciphers are not present in the 'weak' cipher set
and add them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
