garydgregory commented on code in PR #686:
URL:
https://github.com/apache/httpcomponents-core/pull/686#discussion_r3702590260
##########
httpcore5/src/test/java/org/apache/hc/core5/http/ssl/TestTlsCiphers.java:
##########
@@ -94,14 +95,306 @@ void testExcludeWeakNull() {
Assertions.assertNull(TlsCiphers.excludeWeak((String[]) null));
}
+
@Disabled("https://lists.apache.org/thread/2z09rjxv0wpss2gvv9jl8yq9wlst8qmh";)
+ @ParameterizedTest
+ @MethodSource("org.apache.hc.core5.http.ssl.TlsCiphers#getH2Blacklisted()")
+ void testH2BlacklistedIsWeak(final String h2BlacklistedCipherSuite) {
Review Comment:
Maybe refresh the page and choose "squash and merge", I see "No conflicts
with base branch" above a green "squash and merge" button. Or I can merge it if
you want.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
