----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19240/#review37279 -----------------------------------------------------------
shud we have a separate package under monitoring for Riemann. Are we emitting any metrics. helix-core/src/main/java/org/apache/helix/monitoring/MonitoringClient.java <https://reviews.apache.org/r/19240/#comment68696> why do we have batch boolean in the method. Should we not have the interval in the constructor ? helix-core/src/main/java/org/apache/helix/monitoring/MonitoringClient.java <https://reviews.apache.org/r/19240/#comment68716> what is the usage of this method helix-core/src/main/java/org/apache/helix/monitoring/MonitoringEvent.java <https://reviews.apache.org/r/19240/#comment68717> can we have only one shardingKey. Does it make sense to call this shardingKey. Instead user should probably think about the scopes (cluster, resource, partition, participant) ? ShardingKey is probably for advanced users. what do you think? helix-monitor-client/src/main/java/org/apache/helix/monitoring/RiemannClientWrapper.java <https://reviews.apache.org/r/19240/#comment68718> this State will confuse with Helix State, can we make this private if its not used outside of this class or rename the enum helix-monitor-server/src/main/java/org/apache/helix/monitoring/RiemannAgent.java <https://reviews.apache.org/r/19240/#comment68719> can we create constants for heartbeat, running ttl etc helix-monitor-server/src/main/java/org/apache/helix/monitoring/RiemannAlertProxy.java <https://reviews.apache.org/r/19240/#comment68723> dont we have to call zkClient.waitUntilconnected or something ? helix-monitor-server/src/main/java/org/apache/helix/monitoring/RiemannAlertProxy.java <https://reviews.apache.org/r/19240/#comment68724> what happens if zkClient is disconnected and how are the error conditions handled. Can we have some protection here so that it does not bombard ZK more than X writes per second? - Kishore Gopalakrishna On March 14, 2014, 10:17 p.m., Zhen Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19240/ > ----------------------------------------------------------- > > (Updated March 14, 2014, 10:17 p.m.) > > > Review request for helix, Kanak Biscuitwala and Kishore Gopalakrishna. > > > Repository: helix-git > > > Description > ------- > > another refactoring based on last iteration: > 1) remove spectating on monitoring cluster, use a simple round-robin approach > to find the first available monitoring server > 2) add a sharding key in MonitoringEvent > 3) refactor AlertProxy, using direct java function call from clj instead of > jetty/http > > > Diffs > ----- > > helix-core/src/main/java/org/apache/helix/monitoring/MonitoringClient.java > 743f8b4 > helix-core/src/main/java/org/apache/helix/monitoring/MonitoringEvent.java > 80006fb > > helix-monitor-client/src/main/java/org/apache/helix/monitoring/ClientUtil.java > e69de29 > > helix-monitor-client/src/main/java/org/apache/helix/monitoring/RawRiemannClient.java > e69de29 > > helix-monitor-client/src/main/java/org/apache/helix/monitoring/RiemannClientWrapper.java > e69de29 > > helix-monitor-server/src/main/java/org/apache/helix/monitoring/RiemannAgent.java > 61e3d6c > > helix-monitor-server/src/main/java/org/apache/helix/monitoring/RiemannAlertProxy.java > 5fe8ebe > > helix-monitor-server/src/main/java/org/apache/helix/monitoring/RiemannConfigs.java > 193b763 > > helix-monitor-server/src/test/java/org/apache/helix/monitoring/IntegrationTest.java > 9d28dc3 > > helix-monitor-server/src/test/java/org/apache/helix/monitoring/MonitoringTestHelper.java > e69de29 > > helix-monitor-server/src/test/java/org/apache/helix/monitoring/TestClientServerMonitoring.java > 588bc35 > > helix-monitor-server/src/test/java/org/apache/helix/monitoring/TestRiemannAgent.java > 39ece64 > > helix-monitor-server/src/test/java/org/apache/helix/monitoring/TestRiemannAlertProxy.java > 700682a > > helix-monitor-server/src/test/java/org/apache/helix/monitoring/TestRiemannClientWrapper.java > e69de29 > > helix-monitor-server/src/test/java/org/apache/helix/monitoring/TestRiemannMonitoringServer.java > f7d0585 > > Diff: https://reviews.apache.org/r/19240/diff/ > > > Testing > ------- > > > Thanks, > > Zhen Zhang > >
