> On March 14, 2014, 11:58 p.m., Kishore Gopalakrishna wrote: > > shud we have a separate package under monitoring for Riemann. Are we > > emitting any metrics. > > Zhen Zhang wrote: > yes. we can have a separate package for Riemann. we are not emitting > metrics
fixed > On March 14, 2014, 11:58 p.m., Kishore Gopalakrishna wrote: > > helix-core/src/main/java/org/apache/helix/monitoring/MonitoringClient.java, > > line 48 > > <https://reviews.apache.org/r/19240/diff/1/?file=520033#file520033line48> > > > > why do we have batch boolean in the method. Should we not have the > > interval in the constructor ? > > Kanak Biscuitwala wrote: > Since we have sendAndFlush, the batch argument is probably unnecessary. > > Zhen Zhang wrote: > agree. the batch argument can be removed. if batchSize>1, use > batchClient, otherwise use normal client fixed > On March 14, 2014, 11:58 p.m., Kishore Gopalakrishna wrote: > > helix-monitor-client/src/main/java/org/apache/helix/monitoring/RiemannClientWrapper.java, > > line 31 > > <https://reviews.apache.org/r/19240/diff/1/?file=520037#file520037line31> > > > > this State will confuse with Helix State, can we make this private if > > its not used outside of this class or rename the enum > > Zhen Zhang wrote: > will change to private fixed > On March 14, 2014, 11:58 p.m., Kishore Gopalakrishna wrote: > > helix-monitor-server/src/main/java/org/apache/helix/monitoring/RiemannAgent.java, > > line 73 > > <https://reviews.apache.org/r/19240/diff/1/?file=520038#file520038line73> > > > > can we create constants for heartbeat, running ttl etc > > Zhen Zhang wrote: > will do fixed - Zhen ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19240/#review37279 ----------------------------------------------------------- On March 18, 2014, 11:39 p.m., Zhen Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19240/ > ----------------------------------------------------------- > > (Updated March 18, 2014, 11:39 p.m.) > > > Review request for helix, Kanak Biscuitwala and Kishore Gopalakrishna. > > > Repository: helix-git > > > Description > ------- > > another refactoring based on last iteration: > 1) remove spectating on monitoring cluster, use a simple round-robin approach > to find the first available monitoring server > 2) add a sharding key in MonitoringEvent > 3) refactor AlertProxy, using direct java function call from clj instead of > jetty/http > > > Diffs > ----- > > helix-core/src/main/java/org/apache/helix/monitoring/MonitoringClient.java > 743f8b4 > helix-core/src/main/java/org/apache/helix/monitoring/MonitoringEvent.java > 80006fb > > helix-monitor-client/src/main/java/org/apache/helix/monitoring/riemann/ClientUtil.java > e69de29 > > helix-monitor-client/src/main/java/org/apache/helix/monitoring/riemann/RawRiemannClient.java > e69de29 > > helix-monitor-client/src/main/java/org/apache/helix/monitoring/riemann/RiemannClientWrapper.java > e69de29 > helix-monitor-server/pom.xml 2cbddfd > > helix-monitor-server/src/main/java/org/apache/helix/monitoring/riemann/HelixAlertMessenger.java > 5fe8ebe > > helix-monitor-server/src/main/java/org/apache/helix/monitoring/riemann/RiemannAgent.java > 61e3d6c > > helix-monitor-server/src/main/java/org/apache/helix/monitoring/riemann/RiemannConfigs.java > 193b763 > > helix-monitor-server/src/main/java/org/apache/helix/monitoring/riemann/RiemannMonitoringServer.java > d4f11a5 > > helix-monitor-server/src/test/java/org/apache/helix/monitoring/MonitoringTestHelper.java > e69de29 > > helix-monitor-server/src/test/java/org/apache/helix/monitoring/riemann/IntegrationTest.java > 9d28dc3 > > helix-monitor-server/src/test/java/org/apache/helix/monitoring/riemann/TestClientServerMonitoring.java > 588bc35 > > helix-monitor-server/src/test/java/org/apache/helix/monitoring/riemann/TestHelixAlertMessenger.java > 700682a > > helix-monitor-server/src/test/java/org/apache/helix/monitoring/riemann/TestRiemannAgent.java > 39ece64 > > helix-monitor-server/src/test/java/org/apache/helix/monitoring/riemann/TestRiemannClientWrapper.java > e69de29 > > helix-monitor-server/src/test/java/org/apache/helix/monitoring/riemann/TestRiemannMonitoringServer.java > f7d0585 > > Diff: https://reviews.apache.org/r/19240/diff/ > > > Testing > ------- > > > Thanks, > > Zhen Zhang > >
