----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19240/ -----------------------------------------------------------
(Updated March 18, 2014, 11:39 p.m.) Review request for helix, Kanak Biscuitwala and Kishore Gopalakrishna. Repository: helix-git Description ------- another refactoring based on last iteration: 1) remove spectating on monitoring cluster, use a simple round-robin approach to find the first available monitoring server 2) add a sharding key in MonitoringEvent 3) refactor AlertProxy, using direct java function call from clj instead of jetty/http Diffs (updated) ----- helix-core/src/main/java/org/apache/helix/monitoring/MonitoringClient.java 743f8b4 helix-core/src/main/java/org/apache/helix/monitoring/MonitoringEvent.java 80006fb helix-monitor-client/src/main/java/org/apache/helix/monitoring/riemann/ClientUtil.java e69de29 helix-monitor-client/src/main/java/org/apache/helix/monitoring/riemann/RawRiemannClient.java e69de29 helix-monitor-client/src/main/java/org/apache/helix/monitoring/riemann/RiemannClientWrapper.java e69de29 helix-monitor-server/pom.xml 2cbddfd helix-monitor-server/src/main/java/org/apache/helix/monitoring/riemann/HelixAlertMessenger.java 5fe8ebe helix-monitor-server/src/main/java/org/apache/helix/monitoring/riemann/RiemannAgent.java 61e3d6c helix-monitor-server/src/main/java/org/apache/helix/monitoring/riemann/RiemannConfigs.java 193b763 helix-monitor-server/src/main/java/org/apache/helix/monitoring/riemann/RiemannMonitoringServer.java d4f11a5 helix-monitor-server/src/test/java/org/apache/helix/monitoring/MonitoringTestHelper.java e69de29 helix-monitor-server/src/test/java/org/apache/helix/monitoring/riemann/IntegrationTest.java 9d28dc3 helix-monitor-server/src/test/java/org/apache/helix/monitoring/riemann/TestClientServerMonitoring.java 588bc35 helix-monitor-server/src/test/java/org/apache/helix/monitoring/riemann/TestHelixAlertMessenger.java 700682a helix-monitor-server/src/test/java/org/apache/helix/monitoring/riemann/TestRiemannAgent.java 39ece64 helix-monitor-server/src/test/java/org/apache/helix/monitoring/riemann/TestRiemannClientWrapper.java e69de29 helix-monitor-server/src/test/java/org/apache/helix/monitoring/riemann/TestRiemannMonitoringServer.java f7d0585 Diff: https://reviews.apache.org/r/19240/diff/ Testing ------- Thanks, Zhen Zhang
