ashvina commented on a change in pull request #2839: fix healthmgr metrics
URL: https://github.com/apache/incubator-heron/pull/2839#discussion_r180151488
 
 

 ##########
 File path: 
heron/healthmgr/src/java/com/twitter/heron/healthmgr/HealthManager.java
 ##########
 @@ -195,6 +195,14 @@ public static void main(String[] args) throws Exception {
 
     setupLogging(cmd, config);
 
+    LOG.fine(Arrays.toString(cmd.getOptions()));
+
+    // Add the SystemConfig into SingletonRegistry
+    SystemConfig systemConfig = SystemConfig.newBuilder(true)
+        .putAll(getOptionValue(cmd, CliArgs.SYSTEM_CONFIG_FILEPATH), true)
+        .putAll(getOptionValue(cmd, CliArgs.OVERRIDE_CONFIG_FILEPATH), 
true).build();
+    
SingletonRegistry.INSTANCE.registerSingleton(SystemConfig.HERON_SYSTEM_CONFIG, 
systemConfig);
 
 Review comment:
   HealthMgr started using Guice for dependency injection and singleton 
management. It seems to have simplified testing. Can we use the same pattern 
here also? Instead of blocking this PR, if you'd like I can try to replace this 
in a new one?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to