ashvina commented on a change in pull request #2839: fix healthmgr metrics
URL: https://github.com/apache/incubator-heron/pull/2839#discussion_r180162927
 
 

 ##########
 File path: heron/executor/src/python/heron_executor.py
 ##########
 @@ -498,7 +498,11 @@ def _get_healthmgr_cmd(self):
                      "--cluster", self.cluster,
                      "--role", self.role,
                      "--environment", self.environment,
-                     "--topology_name", self.topology_name, "--verbose"]
+                     "--topology_name", self.topology_name,
+                     "--metricsmgr_port", self.metrics_manager_port,
+                     "--system_config_file", self.heron_internals_config_file,
 
 Review comment:
   The HealthManager has access to the config directory 
(https://github.com/apache/incubator-heron/blob/master/heron/healthmgr/src/java/com/twitter/heron/healthmgr/HealthManager.java#L171).
 Can the heron internals config file be accessed through the config path?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to