ashvina commented on a change in pull request #2839: fix healthmgr metrics
URL: https://github.com/apache/incubator-heron/pull/2839#discussion_r181212560
 
 

 ##########
 File path: 
heron/healthmgr/src/java/org/apache/heron/healthmgr/HealthManager.java
 ##########
 @@ -329,6 +337,8 @@ protected void configure() {
         bind(String.class)
             .annotatedWith(Names.named(CONF_METRICS_SOURCE_TYPE))
             .toInstance(type);
+        bind(HealthManagerMetrics.class)
+            .toInstance(publishingMetricsRunnable);
 
 Review comment:
   Is naming this instance a "Runnable" necessary? What do you think about 
naming it just `metricsPublisher`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to