----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41102/#review111559 -----------------------------------------------------------
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java (line 2332) <https://reviews.apache.org/r/41102/#comment171759> Can you also fix description accordingly to make to generic (remove ORC specific parts)? llap-server/src/java/org/apache/hadoop/hive/llap/cache/BufferUsageManager.java (line 26) <https://reviews.apache.org/r/41102/#comment171760> Interface audience + javadoc? llap-server/src/java/org/apache/hadoop/hive/llap/cache/SimpleAllocator.java (line 47) <https://reviews.apache.org/r/41102/#comment171761> How frequently is this called? If it is called frequently, then cost of allocateDirect() will be very high as direct allocation will sleep for 100ms when reserving direct memory. llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapIoImpl.java (line 76) <https://reviews.apache.org/r/41102/#comment171762> ignoreCase to be safer llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapIoImpl.java (line 120) <https://reviews.apache.org/r/41102/#comment171763> Shouldn't this be other way? If useAllocOnly is true then we use SimpleAllocator without cache right? llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/OrcEncodedDataReader.java (line 620) <https://reviews.apache.org/r/41102/#comment171764> Whis is this outside if condition? Can you put this all inside a single if not null condition? - Prasanth_J On Dec. 8, 2015, 9:20 p.m., Sergey Shelukhin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41102/ > ----------------------------------------------------------- > > (Updated Dec. 8, 2015, 9:20 p.m.) > > > Review request for hive and Prasanth_J. > > > Repository: hive-git > > > Description > ------- > > see jira > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java d52f994 > data/conf/hive-site.xml 2ebb1c4 > data/conf/llap/hive-site.xml 9440611 > llap-server/src/java/org/apache/hadoop/hive/llap/cache/BuddyAllocator.java > 0c96efa > > llap-server/src/java/org/apache/hadoop/hive/llap/cache/BufferUsageManager.java > PRE-CREATION > llap-server/src/java/org/apache/hadoop/hive/llap/cache/LowLevelCache.java > b17edb5 > > llap-server/src/java/org/apache/hadoop/hive/llap/cache/LowLevelCacheImpl.java > c2a130a > > llap-server/src/java/org/apache/hadoop/hive/llap/cache/LowLevelCacheMemoryManager.java > 8788e15 > > llap-server/src/java/org/apache/hadoop/hive/llap/cache/LowLevelLrfuCachePolicy.java > 40cb92d > llap-server/src/java/org/apache/hadoop/hive/llap/cache/SimpleAllocator.java > PRE-CREATION > > llap-server/src/java/org/apache/hadoop/hive/llap/cache/SimpleBufferManager.java > PRE-CREATION > llap-server/src/java/org/apache/hadoop/hive/llap/cli/LlapServiceDriver.java > 08d573b > > llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/LlapDaemon.java > dbdf571 > > llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapIoImpl.java > b38f472 > > llap-server/src/java/org/apache/hadoop/hive/llap/io/decode/OrcColumnVectorProducer.java > 259c483 > > llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/OrcEncodedDataReader.java > 885acc0 > > llap-server/src/test/org/apache/hadoop/hive/llap/cache/TestBuddyAllocator.java > 6375996 > > llap-server/src/test/org/apache/hadoop/hive/llap/cache/TestLowLevelCacheImpl.java > 8324b21 > > llap-server/src/test/org/apache/hadoop/hive/llap/cache/TestLowLevelLrfuCachePolicy.java > d0abfa3 > > Diff: https://reviews.apache.org/r/41102/diff/ > > > Testing > ------- > > > Thanks, > > Sergey Shelukhin > >
