----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41102/#review111571 -----------------------------------------------------------
llap-server/src/java/org/apache/hadoop/hive/llap/cache/SimpleAllocator.java (line 54) <https://reviews.apache.org/r/41102/#comment171778> Are you sure this will be GC'ed properly for direct memory? I remember something about using clean() for direct BB. If not cleaned properly this can trigger full GC to clear off unused memory. - Prasanth_J On Dec. 22, 2015, 2:13 a.m., Sergey Shelukhin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41102/ > ----------------------------------------------------------- > > (Updated Dec. 22, 2015, 2:13 a.m.) > > > Review request for hive and Prasanth_J. > > > Repository: hive-git > > > Description > ------- > > see jira > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java d2dd9c6 > data/conf/hive-site.xml 2a5f891 > data/conf/llap/hive-site.xml e3425c8 > llap-server/src/java/org/apache/hadoop/hive/llap/cache/BuddyAllocator.java > 0c96efa > > llap-server/src/java/org/apache/hadoop/hive/llap/cache/BufferUsageManager.java > PRE-CREATION > llap-server/src/java/org/apache/hadoop/hive/llap/cache/LowLevelCache.java > b17edb5 > > llap-server/src/java/org/apache/hadoop/hive/llap/cache/LowLevelCacheImpl.java > c2a130a > > llap-server/src/java/org/apache/hadoop/hive/llap/cache/LowLevelCacheMemoryManager.java > 8788e15 > > llap-server/src/java/org/apache/hadoop/hive/llap/cache/LowLevelLrfuCachePolicy.java > 40cb92d > llap-server/src/java/org/apache/hadoop/hive/llap/cache/SimpleAllocator.java > PRE-CREATION > > llap-server/src/java/org/apache/hadoop/hive/llap/cache/SimpleBufferManager.java > PRE-CREATION > llap-server/src/java/org/apache/hadoop/hive/llap/cli/LlapServiceDriver.java > 8e5377f > > llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/LlapDaemon.java > 467ab71 > > llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapIoImpl.java > b38f472 > > llap-server/src/java/org/apache/hadoop/hive/llap/io/decode/OrcColumnVectorProducer.java > e156eaa > > llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/OrcEncodedDataReader.java > 58d2ac8 > > llap-server/src/test/org/apache/hadoop/hive/llap/cache/TestBuddyAllocator.java > 6375996 > > llap-server/src/test/org/apache/hadoop/hive/llap/cache/TestLowLevelCacheImpl.java > 8324b21 > > llap-server/src/test/org/apache/hadoop/hive/llap/cache/TestLowLevelLrfuCachePolicy.java > d0abfa3 > > Diff: https://reviews.apache.org/r/41102/diff/ > > > Testing > ------- > > > Thanks, > > Sergey Shelukhin > >
